Single Dockerfile for multi-arch builds #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the need of keeping two Dockerfiles for different architectures. However, it still relies on docker-compose to build release versions or the .ci/build-images.sh for continuous integration builds. In terms of release builds, these will only be built when a tag is given to ci/travis. This is in preparation for the multi-arch push to docker hub. There is still a need in the future to accomodate other OSes inside the container folder, such as Alpine.
PFigs
force-pushed
the
update-unify-dockerfiles
branch
from
c24ca55 to
658d496
Compare
Merged
added 3 commits
July 15, 2019 10:00
This commit creates a stable folder to contain the release Dockerfile and a common folder to store the templates and docker-entrypoint.
PFigs
force-pushed
the
update-unify-dockerfiles
branch
from
7941a76 to
6824fb6
Compare
* Readme update This commit adds an overview of the gateway services and updates the instructions on how to build, pull and run with docker. Closes #62
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
added 2 commits
July 15, 2019 15:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the need of keeping two Dockerfiles for
different architectures.
However, it still relies on docker-compose to build release
versions or the .ci/build-images.sh for continuous integration
builds.
In terms of release builds, these will only be built when a tag
is given to ci/travis. This is in preparation for the multi-arch
push to docker hub.
There is still a need in the future to accomodate other OSes inside
the container folder, such as Alpine.