-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Generate fixed-layout output (PDF or similar) #304
Comments
Please take a look at PR #239 and try out the related branch to test if most of your suggested features will be covered. You can also comment in this PR any outstanding issues to meet your requirements. |
I looked both at PR #239 as well as underlying feature/technical-drw branch, they both crash even when I am trying to run them against the "official" demo project (demo02.yml) out-of-the-box by simply calling
followed by complete dump of the YAML file content (truncated here for brevity). It seems like a call to Path(inp).expanduser().resolve(strict=True) in wireviz.py:389 fails to raise the exception and instead it just crashes when YAML string is fed into resolve() instead of the path. Am I doing something wrong? Also, even if I am doing something wrong, it does not seem to be a safe and sound practice to feed the content of an arbitrary YAML file into the file path analysis function in order to try to differentiate between the path and YAML. |
I'm sorry, @nyq that I wasn't fully updated on the state of #239. You are right the included demo02 fails in this branch. However, @formatc1702 has joined several of his PRs (including #239) into #251 - where he also makes improvements. The demo02 does not currently fail in this branch, so please try that one instead. Feel free to make comments/reviews in #251 about your findings. |
Harness diagrams, when used in production environment, need to be in some fixed-layout document format because that document needs to go through the design review, approval and release processes. Surely one can take HTML output produced by WireViz and manually "print" it into PDF format, but it would be more useful if the tool had an option for direct generation of PDF. Manually generating PDFs out of HTML is not only adding an extra step, but it also requires playing with scaling factor depending on the size of the diagrams in HTML file. At a minimum, PDF output solution would need to meet the following requirements:
The text was updated successfully, but these errors were encountered: