-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] OSError: [WinError 123] with version 0.4 #344
Comments
@KlopDesign - Thank's for trying out our new release, and reporting your problem here! Can you please provide the information specified in CONTRIBUTING.md to enable others to re-create your error situation. Please also tell us how you installed WireViz and dependencies. I also hope you can provide a dump of your CMD window where the error message appear (hopefully also showing your latest commands, exception trace, and your current directory. |
I have experience a similar issue. All problems go away when reverting to version 0.3 I get the error below when trying to create any of the example diagrams
|
Same issue here. I have installed the new version with "pip install --upgrade wireviz" |
I also have this issue when trying to call WireViz 0.4 |
It seems you have found a bug that isn't triggered by the tests we have done. How do you execute WireViz? Please include a copy of the command line including arguments. If you call it from another code or script, please include that, but please strip it down to a minimum if it's large. |
I cd into the directory of the.yml file, then simply "wireviz u1.yml" like before. |
Windows Command Prompt:
|
I'm not able to reproduce the reported OSError here, but I notice my Python version is older than what @alecraymond uses, but newer than what @KlopDesign uses. My Graphviz versions is also older than what @alecraymond uses, but as far as I know, the Graphviz I hope more users (both those who see this error and those who don't) will report their version numbers, because that can help finding a pattern about what is working and what is not.
|
Trying to replicate your results, I noticed some differences:
I will try again using an empty starting directory, python 3.9.13, and
|
I have updated my log above to also include the extra commands @alecraymond just used, in case it might help to compare... |
Another attempt with all other versions of python removed. There may be an issue with my graphviz installation this time, since
|
I'm getting the same issue. Whatever the root cause is, the issue seems to be that the error type raised isn't My fix, without understanding any of the underlying code: At https://github.com/wireviz/WireViz/blob/master/src/wireviz/wireviz.py#L413 Change the next few lines to:
|
Suggested fix posted in wireviz#344 (comment) Co-authored-by: JarrettR <jrainier@gmail.com>
@JarrettR - Thank's a lot for finding the errno value of the raised OSError and suggesting the fix! I've not yet been able to reproduce this error myself. Since you posted the fix here instead of creating a PR, I took the liberty to create PR #346 and adding you as an author. Some users find it easier to test such a fix from an existing branch instead of modifying the code themselves. If you disagree how I did this, please explain how you rather want it, and we can look into it. @KlopDesign @dmason1992 @freiadam @alecraymond @JarrettR and others experiencing this error, please test the fix in the branch of PR #346 and report back the outcome together with your OS and versions. |
The fix works for me:
|
Suggested fix posted in #344 (comment) Co-authored-by: JarrettR <jrainier@gmail.com>
Suggested fix posted in #344 (comment) Co-authored-by: JarrettR <jrainier@gmail.com>
Suggested fix posted in #344 (comment) Co-authored-by: JarrettR <jrainier@gmail.com>
|
I can confirm the issue.
Windows version: Python version:
After trying the fix, I still get the error, but the .yml compiles and exports the
|
@Basilisvirus the latter error message indicates the following issue/fix
It should be fixed with the next release, so please try the commands from my comment above ==> #344 (comment) |
The relevant fixes are merged into the |
In Windows might OSError(errno=EINVAL) be raised instead of the already catched exceptions in some cases (depending on the Python version). Suggested fix posted by JarrettR in #344 (comment) Co-authored-by: JarrettR <jrainier@gmail.com>
Closed after releasing v0.4.1. |
Thanks for the great tool! However, with version WireViz 0.4 I cannot get a good output.
With
wireviz demo01.yml
andwireviz tutorial01.yml
I get:OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: ...
Python version 3.7.0 using pyenv.
I installed WireViz 0.3.2 and that one works just fine. However, demo02.yml does not work as in #304: Exception: First item not found anywhere.
Edit 14-05-2024: hereby my cmd output. Installed Python via pyenv:
pyenv install 3.7.0
The demo01.yml is the same as in the repository.
The text was updated successfully, but these errors were encountered: