-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle OSError [errno.EINVAL] that might be raised in Windows #346
Conversation
Suggested fix posted in wireviz#344 (comment) Co-authored-by: JarrettR <jrainier@gmail.com>
This commit fixed it for me 👍
|
pip uninstall wireviz pip install wireviz I have replaced wireviz.py with the edited file -> `PS C:\Users\adam\Wireviz\psyduck\J2_GND> wireviz j2.yml WireViz 0.4 |
@freiadam wrote:
Thank you for testing this PR. The exception you report now seems to be caused by the other bug already reported in #345. Please also comment there about your findings if you agree. The fact that you got an exception trying to read a template file (that is part of HTML output after processing all YAML input) proves that the bug targeted by this PR was not triggered, because the #344 bug is located in the code part that opens the YAML input before it gets parsed. 😃 |
Suggested fix posted in #344 (comment) Co-authored-by: JarrettR <jrainier@gmail.com>
Same error as Original post. wireviz-0.4.1.dev0 fixed issue. |
In Windows might OSError(errno=EINVAL) be raised instead of the already catched exceptions in some cases (depending on the Python version). Suggested fix posted by JarrettR in #344 (comment) Co-authored-by: JarrettR <jrainier@gmail.com>
Suggested fix posted in
#344 (comment)
Please verify that this fixes #344 and report back.
The base branch of this PR ismaster
for the time beeing, but it should be changed to a new release/v0.4.1-rc before any merge-in. #345 should also be fixed and updating the changelog before releasing the hotfix.