Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the types of dataclass attributes according to usage #163

Merged
merged 2 commits into from
Nov 1, 2020
Merged

Update the types of dataclass attributes according to usage #163

merged 2 commits into from
Nov 1, 2020

Commits on Oct 23, 2020

  1. Update the types of dataclass attributes according to usage 

    Fixes wireviz#156
    @kvid
    kvid committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a050e9d View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2020

  1. Add type aliases that reflect their semantics 

    Using Any or str in type annotations might increase the need for extra
comments to explain the real valid values. However, such needs can be
drastically reduced with the help of semanticly named type aliases.

Each type alias have their legal values described in comments.
Actual validation might be implemented in the future.
    @kvid
    kvid committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    c04804c View commit details
    Browse the repository at this point in the history