Detect and assign unit within cable length attribute #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formatc1702
force-pushed
the
feature/auto-length-unit
branch
from
6fb0467 to
1d29c6c
Compare
kvid
requested changes
Nov 28, 2020
Co-authored-by: kvid <kvid@users.noreply.github.com>
|
Thanks for the suggestions, they've all been included. |
kvid
approved these changes
Dec 7, 2020
kvid
added a commit
to kvid/WireViz
that referenced
this pull request
Dec 26, 2020
Bug: Failing to assign the default cable length unit when not present. It was introduced in wireviz#198. Fix: Test the correct cable attribute. This fix solves issue wireviz#205.
formatc1702
pushed a commit
that referenced
this pull request
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on new
length_unitattribute from #196.