-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated GitHub Actions and add Python versions #408
Conversation
actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024. Learn more. Similarly, v1/v2 are scheduled for deprecation on June 30, 2024. Please update your workflow to use v4 of the artifact actions.
Breaking change in upload-artifact@v4: Uploading to the same named Artifact multiple times. Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.
Additionally, I suggest adding the following action: Compare build artifacts from two different commits via github actions |
Note that I have enable PyLint as an additional GH action in my personal repo: It reports some errors on the current code base that might need fixing...
If you think that it is useful to add it here as well, then let me know! |
I don't have enough experience with It seems
|
See an interesting article on this topic TL;DR Recommendation:
Further reading and a cheat sheet Personally, I am relying on VScode's Pyright and Pylance, though that is partially closed source, so it is only a conditional recommendation. See DetachHead/basedpyright for details and alternatives. |
Hi. On linting and code formatting concerns, I dearly recommend to use Ruff these days. I am sure you will never look back. |
Do you agree, @martinrieder, @formatc1702, @amotl, and any others with an opinion? |
I have very limited experience with GH Actions, linters, etc. but here are my main points:
I see no problem here, go ahead 👍
Cherry-picking should be enough to avoid rebase hell ;)
Are you suggesting use of these tools should be enforced for all contributors? Would this increase the difficulty for new contributors? As someone who has not used these tools (beside |
@formatc1702 - Thank's for responding!
The same goes for me, I'm afraid (except isort & black).
Thank's - I'll do this within in a couple of days, unless someone else present a better alternative before then.
I see your point, but I think we can let the PR authors decide for each case. In some cases, getting also all the latest bugfixes might be worth handling a few conflicts.
@martinrieder must answer for his suggestions himself, but I suggest moving any additional actions to new PR(s). |
Running 6 different Python versions (3.7 to 3.12) in parallel now. NOTE: This is in conflict with wireviz#309, but can be resolved easily in a later PR. GitHub Actions require an update: - actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024. - Similarly, v1/v2 are scheduled for deprecation on June 30, 2024. - Updating this comes with a breaking change in upload-artifact@v4: Uploading to the same named Artifact multiple times. Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error. The artifact .zip files therefore have the python version added to their name.
Running 6 different Python versions (3.7 to 3.12) in parallel now.
NOTE: This is in conflict with #309, but can be resolved easily.
GitHub Actions require an update:
Uploading to the same named Artifact multiple times.
The artifact .zip files therefore have the python version added to their name.