-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cleaning of examples #94
Conversation
build_examples supports cleaning examples and intelligently will detect new examples. SUGGESTION: When merging into dev, require ``` build_examples.py clean ``` and then only build when merging into master branch
This looks like a really useful improvement! Thanks! |
Any idea how it chooses the order of the files? Any quick way to fix this?
|
Also, I'm not sure cleaning up (by deleting) the examples pre-merge is the best course of action, because then the readme of the What I've been doing is simply discarding any changes I've made to the output files before commiting anything to As the project matures, there probably will be less and less changes that affect the output files, but who knows. |
Perhaps one option would be to keep examples out of the repo completely (by |
Personally, I'm actively using the input files together with the output files (those that don't depend on the Graphviz version) for regression testing to verify that my commits either don't change any output or produce the expected output diff. That's also why I suggested issue #63 I would therefore prefer to keep these files unless the regression testing can be secured some other way. Why not change the |
If Two advantages by copying the YAML file to the subfolder first:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider sorting the list returned from os.listdir()
(called 4 places?) as suggested here: https://stackoverflow.com/questions/4813061/non-alphanumeric-list-order-from-os-listdir
See unsorted output in #94 (comment)
build_examples supports cleaning examples and intelligently will detect new examples.
SUGGESTION: When merging into dev, require
and then only build when merging into master branch
This should allow easier merges, especially from windows, and I am using it as part of a resolution to one of the requests in #17