Skip to content

Display different column in reference field #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@ import play.api.libs.json.{Format, Json}
object AdminGetTables {
case class Response(data: List[Response.DatabaseTable])
object Response {
case class DatabaseTable(name: String, columns: List[TableColumn], primaryKeyName: String, canBeDeleted: Boolean)
case class DatabaseTable(
name: String,
columns: List[TableColumn],
primaryKeyName: String,
canBeDeleted: Boolean,
referenceDisplayField: Option[String]
)
case class TableColumn(
name: String,
`type`: String,
Expand Down
1 change: 1 addition & 0 deletions spra-play-server/src/main/resources/application.conf
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ dataExplorer {
createFilter {
requiredColumns = ["user_id", "message"]
}
referenceDisplayField = "email"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,14 @@ case class TableSettings(
primaryKeyDataType: PrimaryKeyDataType = PrimaryKeyDataType.UUID,
columnTypeOverrides: Map[String, CustomDataType] = Map.empty,
filterableColumns: List[String] = List.empty,
createSettings: CreateSettings = CreateSettings()
createSettings: CreateSettings = CreateSettings(),
referenceDisplayField: Option[String] = None
) {
override def toString: String =
s"""TableSettings(tableName = $tableName, primaryKeyField = $primaryKeyField, referenceField = $referenceField,
hiddenColumns = $hiddenColumns, nonEditableColumns = $nonEditableColumns, canBeDeleted = $canBeDeleted,
primaryKeyDataType = $primaryKeyDataType, columnTypeOverrides = $columnTypeOverrides,
filterableColumns = $filterableColumns, createSettings = $createSettings)"""
filterableColumns = $filterableColumns, createSettings = $createSettings, referenceDisplayField: $referenceDisplayField)"""
}

object TableSettings {
Expand Down Expand Up @@ -102,7 +103,8 @@ object TableSettings {
createSettings = CreateSettings(
requiredColumns = getList[String]("createFilter.requiredColumns"),
nonRequiredColumns = getList[String]("createFilter.nonRequiredColumns")
)
),
referenceDisplayField = getOption[String]("referenceDisplayField")
)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import net.wiringbits.spra.admin.config.{CustomDataType, DataExplorerConfig, Tab
import net.wiringbits.spra.admin.repositories.DatabaseTablesRepository
import net.wiringbits.spra.admin.repositories.models.{ForeignKey, TableData}
import net.wiringbits.spra.admin.utils.models.QueryParameters
import net.wiringbits.spra.admin.utils.{MapStringHideExt, contentRangeHeader}
import net.wiringbits.spra.admin.utils.contentRangeHeader
import net.wiringbits.spra.api.models.*

import java.awt.image.BufferedImage
Expand Down Expand Up @@ -78,17 +78,14 @@ class AdminService @Inject() (
name = settings.tableName,
columns = columns,
primaryKeyName = settings.primaryKeyField,
canBeDeleted = settings.canBeDeleted
canBeDeleted = settings.canBeDeleted,
referenceDisplayField = settings.referenceDisplayField
)
}
}
} yield AdminGetTables.Response(items)
}

private def hideData(tableData: TableData, hiddenColumns: List[String]) = {
tableData.data.hideData(hiddenColumns)
}

def tableMetadata(tableName: String, queryParams: QueryParameters): Future[(List[Map[String, String]], String)] = {
val validations = {
for {
Expand All @@ -102,9 +99,8 @@ class AdminService @Inject() (
_ <- validateQueryParameters(tableName, queryParams)
tableRows <- databaseTablesRepository.getTableMetadata(settings, queryParams)
numberOfRecords <- databaseTablesRepository.numberOfRecords(tableName)
hiddenTableData = tableRows.map(data => hideData(data, settings.hiddenColumns))
contentRange = contentRangeHeader(tableName, queryParams, numberOfRecords)
} yield (hiddenTableData, contentRange)
} yield (tableRows.map(_.data), contentRange)
}

private def validateQueryParameters(tableName: String, params: QueryParameters): Future[Unit] = {
Expand All @@ -129,9 +125,7 @@ class AdminService @Inject() (
_ <- validations
maybe <- databaseTablesRepository.find(tableName, primaryKeyValue)
tableRow = maybe.getOrElse(throw new RuntimeException(s"Cannot find item in $tableName with id $primaryKeyValue"))
settings = dataExplorerConfig.unsafeFindByName(tableName)
hiddenData = hideData(tableRow, settings.hiddenColumns)
} yield hiddenData
} yield tableRow.data
}

def find(tableName: String, primaryKeyValues: List[String]): Future[List[Map[String, String]]] = {
Expand All @@ -141,7 +135,6 @@ class AdminService @Inject() (

for {
_ <- validations
settings = dataExplorerConfig.unsafeFindByName(tableName)
tableRows <- Future.sequence {
primaryKeyValues.map { primaryKeyValue =>
for {
Expand All @@ -152,8 +145,7 @@ class AdminService @Inject() (
} yield tableData
}
}
maskedTableData = tableRows.map(x => hideData(x, settings.hiddenColumns))
} yield maskedTableData
} yield tableRows.map(_.data)
}

def create(tableName: String, request: AdminCreateTable.Request): Future[String] = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@ package object utils {
}
}

implicit class MapStringHideExt(val data: Map[String, String]) extends AnyVal {
def hideData(columnsToHide: List[String]): Map[String, String] = {
data.filterNot { case (key, _) => columnsToHide.contains(key) }
}
}

def contentRangeHeader(tableName: String, queryParameters: QueryParameters, numberOfRecords: Int): String = {
s"$tableName ${queryParameters.pagination.start}-${queryParameters.pagination.end}/$numberOfRecords"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,13 @@ object CreateGuesser {
reference = reference,
isRequired = isRequired,
validate = required
)(SelectInput(optionText = source, isRequired = isRequired, validate = required))
)(
SelectInput(
optionText = props.response.referenceDisplayField.getOrElse(source),
isRequired = isRequired,
validate = required
)
)
}
}
.getOrElse(Fragment())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,13 @@ object EditGuesser {
ReferenceInput(
source = field.name,
reference = reference
)(SelectInput(optionText = source, disabled = field.disabled))
)(
SelectInput(
source = source,
optionText = props.response.referenceDisplayField.getOrElse(source),
disabled = field.disabled
)
)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ object ListGuesser {
case Image => ImageField(source = field.name, sx = styles)
case Number => NumberField(source = field.name)
case ColumnType.Reference(reference, source) =>
defaultField(reference, field.name)(TextField(source = source))
defaultField(reference, field.name)(
TextField(source = props.response.referenceDisplayField.getOrElse(source))
)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,20 @@ import scala.scalajs.js.|

object SelectInput extends ExternalComponent {
case class Props(
optionText: String = "",
source: String = "",
disabled: Boolean = false,
isRequired: Boolean = false,
validate: js.UndefOr[js.Any] = js.undefined
validate: js.UndefOr[js.Any] = js.undefined,
optionText: js.UndefOr[String] = js.undefined
)

def apply(
optionText: String = "",
source: String = "",
disabled: Boolean = false,
isRequired: Boolean = false,
validate: js.UndefOr[js.Any] = js.undefined
): BuildingComponent[_, _] = super.apply(Props(optionText, disabled, isRequired, validate))
validate: js.UndefOr[js.Any] = js.undefined,
optionText: js.UndefOr[String] = js.undefined
): BuildingComponent[_, _] = super.apply(Props(source, disabled, isRequired, validate, optionText))

override val component: String | js.Object = ReactAdmin.SelectInput
}