Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voting Power rule should only accept values between 0-100 (with max 2 decimal places) #37

Open
2 of 5 tasks
noisy opened this issue Dec 11, 2018 · 3 comments
Open
2 of 5 tasks

Voting Power rule should only accept values between 0-100 (with max 2 decimal places) #37

noisy opened this issue Dec 11, 2018 · 3 comments
Assignees
@Jblew
Labels
bug Something isn't working well defined If you want to contribute, take task like this

Comments

@noisy
Copy link
Contributor

noisy commented Dec 11, 2018 •
edited by Jblew
Loading

The problem:

it is possible to setup a rule with a value of Voting Power outside of range [0:100]

I did:

selection_999 681

I expected to see:

A form should not allow me to type value greater than 100

Links to steemd / steemit : https://steemd.com/tx/6407e176e75bf1562353af27f85bf6f767de6470

This task is in proggress, this is a TODO:

  • - update Validator in steem-wise-core
  • - release steem-wise-core
  • - update steem-wise-core in wise-hub and steem-wise-voter-page
  • - update UI in wise-hub (apply range, and decimal format)
  • - update UI in steem-wise-voter-page (apply decimal format)
@noisy noisy added the bug Something isn't working label Dec 11, 2018
@noisy
Copy link
Contributor Author

noisy commented Dec 11, 2018

Another strange issue:

value 1.1111%:
selection_999 682

is translated into 111:
"["v2:set_rules",{"voter":"wise-test1","rulesets":[["Vote if I have 1.1111% of voting power",[{"rule":"voting_power","mode":"more_than","value":111}]]]}]"

https://steemd.com/tx/b931c1ebc4169caa40ecbe9ab4587930c72bce9b

@noisy noisy added the well defined If you want to contribute, take task like this label Dec 14, 2018
@Jblew
Copy link
Member

Jblew commented Jan 4, 2019 •
edited
Loading

This task is due. TODO list was placed at the top, to enable proggress monitoring in board

Jblew added a commit to wise-team/steem-wise-core that referenced this issue Mar 8, 2019
@Jblew
fix(voting power rule): limit value wise-team/wise-hub#37
21a69c6
@Jblew
Copy link
Member

Jblew commented Mar 8, 2019

@noisy

Another strange issue:

value 1.1111%: [...] is translated into 111: [...]

It is correct. In steem 111/10000 = 1,11% (two-digit precision)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jblew Jblew

Labels
bug Something isn't working well defined If you want to contribute, take task like this
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noisy @Jblew