Update code from iamthebot/cld3 and google/cld3 (New) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CMake script to buid a static lib cld3 and unittests. No dependancy with Chrome.
Add CMake script to buid a static lib cld3 and unittests. No dependancy with Chrome.
Conflicts: CMakeLists.txt
Fix -Wextra-semi warnings.
small fix for BUILD.gn
Add CMake script
Exposes each ScriptSpan prediction in LangChunkStats.
…ebot-master # Conflicts: # .gitignore # README.md # setup.py # src/cld3.pyx
bact
changed the title
|
FYI @bact , I've verified that https://github.com/bsolomon1124/pycld3 contains everything included here (and then some small updates on top). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if str(res.language) != ident.kUnknown:comparison toif <bytes> res.language != <bytes> ident.kUnknown:See discussion about the fixes here google#15