Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add skip test flag #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add skip test flag #170

wants to merge 1 commit into from

Conversation

chriskarlin
Copy link
Contributor

No description provided.

chriskarlin
chriskarlin commented Sep 27, 2024
View reviewed changes
go/build-and-test/action.yml
@@ -36,6 +36,10 @@ inputs:
description: A timeout value in seconds. If tests take longer than this, they will fail. Not setting this value will fallback to go test's default of 10 minutes.
required: false
default: ""
SKIP_TESTS:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
SKIP_TESTS:
SKIP_TEST:

dcbickfo
dcbickfo requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@dcbickfo dcbickfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you managed this in a different way, but my vote would be to have a separate build action (like what we had when I was playing with caching) and let the calling workflow skip running the tests rather than skipping part of this action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbickfo dcbickfo dcbickfo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriskarlin @dcbickfo