Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alloy Forgery] Fix various links, formatting, spelling, and grammatical mistakes #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Dragon-Seeker
Copy link
Member

No description provided.

Copy link
Member

@Noaaan Noaaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some more sentences to improve, see the review comments

docs/alloy-forgery/adding-recipes-and-fuels.md Outdated Show resolved Hide resolved
docs/alloy-forgery/recipe-adaptation.md Outdated Show resolved Hide resolved
- Add info about datapack tutorial within the af home page
@Noaaan
Copy link
Member

Noaaan commented Jun 27, 2024

Re-requesting review as I do believe this needs more changes that we missed when last looking at it (like broken images)

@Noaaan Noaaan self-requested a review June 27, 2024 10:49
@@ -3,9 +3,9 @@ title: Recipe Adaptation
project: alloy-forgery
---

Since 2.1.0, Alloy Forgery comes with a System to adapt existing eecipes to alloy forging recipes with the only current implementation of the system being used to adapt existing Blast Furnace recipes to work within the forge.
Since 2.1.0, Alloy Forgery added a system to adapt existing recipes to alloy forging recipes. Currently, only Blast Furnace recipes are adapted to work with the forge.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Since 2.1.0, Alloy Forgery added a system to adapt existing recipes to alloy forging recipes. Currently, only Blast Furnace recipes are adapted to work with the forge.
Since 2.1.0, Alloy Forgery added a system to adapt existing recipes to Alloy Forging recipes. Currently we only automatically adapt Blast Furnace recipes.


Developed alongside this adaptation system is the ability to create tags for Recipes with such following the same format as any other tag just being the tags should be placed within the `{your_namespace_here}/tags/recipes/` folder within your datapack
Developed alongside this adaptation system is the ability to create tags for Recipes with such following the same format as any other tag just being the tags should be placed within the `{your_namespace_here}/tags/recipes/` folder within your datapack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Developed alongside this adaptation system is the ability to create tags for Recipes with such following the same format as any other tag just being the tags should be placed within the `{your_namespace_here}/tags/recipes/` folder within your datapack.
Developed alongside this adaptation system is the ability to create tags for Recipes. These work like any other tag, and belongs under the `{your_namespace_here}/tags/recipes/` folder within your datapack.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated, as Deepslate is now tier 1 instead of tier 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants