fix: use fs read instead of JSON import #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dee9936 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
approved these changes
Dec 18, 2023
MoustaphaDev
approved these changes
Dec 18, 2023
Merged
|
@Skn0tt Thanks for the fix. I'm cutting a patch release now. Just a general information, we tend to keep the format of the changeset in the present tense (sometimes we don't catch that in reviews, and it is not a hard rule), but just so you know: |
|
Thanks for letting me know, will try to remember it next time :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #104.
We were crashing when importing the adapter because importing JSON isn't supported on all versions of Node.js. This PR replaces it with
readFileinstead. We could've used import assertions instead, but then we'd also need to change some typescript settings which is risky.Testing
tested locally.
Docs
no docs needed, it's a fix.