fix(netlify): replace global.crypto with crypto

[OiYouYeahYou]

Changes

This is a drive by change because randomUUID is not on the global version of crypto on my node version (v18.18.2). I'm uncertain if this breaks any compatibility for others and do not have pnpm to run and commands.

Testing

Not testing done because this is a trivial change and don't have pnpm

Docs

Trivial change, probably should be noted in changelog

[changeset-bot]

🦋 Changeset detected

Latest commit: 14e01c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@astrojs/netlify	Patch
@test/netlify-hosted-astro-project	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[alexanderniebuhr]

cc @Skn0tt, wdyt about this change?

[bluwy]

In Astro, it does polyfill the global crypto object here. Does it fail for you? Or are you loading the netlify integration manually outside of Astro?

[Skn0tt]

Looks fine to me!

I don't think the global crypto polyfill will work, because this is about usage within the build, not within the runtime. And we only put that polyfill in place for the runtime.

[bluwy]

The code I linked is used to apply the polyfill in build time. https://github.com/withastro/astro/blob/2dbb6a3e082bd1e33cc0de2f10417a012ae89243/packages/astro/src/core/build/index.ts#L68

[Skn0tt]

Interesting, didn't know that! So why is globalThis.crypto undefined for @OiYouYeahYou? 🤔

[OiYouYeahYou]

So I've just tested in a docker (node:18-alpine) and node does not have it on globalThis. It is global in REPL, I assume as an enhancement like 'fs' et al is. So, I assume that the polyfill just doesn't have 100% coverage.

As Node 18 is still maintenance for another year, I still thing this is a valid change. But perhaps this is the wrong change to fix this problem.

I will highlight though, the other packages in this repo import crypto instead of using the global version

[lilnasy]

@OiYouYeahYou does it only happen with the astro add command?

withastro/astro#10105

[OiYouYeahYou]

@lilnasy If I remember rightly, this was a blocker on npm run dev for me

[lilnasy]

I can only reproduce it with astro add and a few other commands (fixed by withastro/astro#10105), but the dev command seems to be correctly polyfilled. Do you think something else about your project could be involved?

[lilnasy]

Looks great to me!

The PR to astro will enable the use of crypto and File in the config file for new versions. This PR can help with compatibility with older versions.

Could you add a patch changeset with pnpm -w exec changeset? It will show up in CHANGELOG.md.

[sarah11918]

Looks good to docs, but as mentioned in the comment, would love to be specific about version numbers if it's easy, but not a deal breaker!

(Especially if by chance it now works for some older versions, but not all of them, would be nice for people to know whether or not it should work for their version after this fix.)

[sarah11918]

Can we give a version number here to be more specific? Something like:

failed for Astro vx.x and earlier

(Assuming this fix works for all earlier Astro versions. Otherwise, specifying the range would be a nice addition.)

[alexanderniebuhr]

@lilnasy do you know which versions this applies to? I guess: <4.4.1?

[lilnasy]

Yes, it was fixed in 4.4.1.