-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vercel): add support for Node 22 #447
Conversation
🦋 Changeset detectedLatest commit: 8a476e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
We can't make v22 the default because Astro itself doesn't officially support it. |
Doesn't out node version range allow node 22? https://github.com/withastro/astro/blob/cf0d8b08a0f16bba7310d1a92c82b5a276682e8c/packages/astro/package.json#L229 which technically means we support it. And it's also the active LTS now. |
Yeah, sorry, I misunderstood for Node.js v23 😓 |
@bluwy should we point this PR against |
I think it's fine in a minor, but our next major release is also not far away so that's fine by me too if you prefer to do so 👍 |
ce899a9
to
8a476e8
Compare
Changes
Add support for Node 22 on Vercel serverless. Fixes #446.
I'm not sure if this is the approach you'd like. If we have a
default
value forstatus
, and Vercel uses the latest available version as the default, it seems we should've used whatever marked asdefault
as the... default. Right now the code uses Node 18 instead, which is not what theSUPPORTED_NODE_VERSIONS
constant suggests.I considered making Node 22 the default, but I'm worried that it might be considered a breaking change.
Testing
I haven't tested it yet, don't have the time to do it right now but it seems like these changes should be enough to add the support?
Docs
The docs say
Vercel already supports Node 22 now, so the docs are currently misleading, and adding the support will correct it.