Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview image to top level starters #16

Merged
merged 15 commits into from
Sep 3, 2022
Merged

Add preview image to top level starters #16

merged 15 commits into from
Sep 3, 2022

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Sep 1, 2022

In response to withastro/astro#4541 (Day 1)

Adds screenshot previews to the starter options currently available in create-astro. Nothing fancy! But ... exists? Some prep work done for someone who knows what they're doing! (@delucis ? Do you need some Launch Pad cred??) 😅

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for astro-new ready!

Name Link
🔨 Latest commit f15ca81
🔍 Latest deploy log https://app.netlify.com/sites/astro-new/deploys/631373781c52590008516cb4
😎 Deploy Preview https://deploy-preview-16--astro-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918 sarah11918 marked this pull request as ready for review September 1, 2022 03:38
@sarah11918 sarah11918 mentioned this pull request Sep 1, 2022
29 tasks
@delucis
Copy link
Member

delucis commented Sep 3, 2022

Took a pass at this, let me know what you think!

@sarah11918
Copy link
Member Author

sarah11918 commented Sep 3, 2022

Obvs I do like these improvements @delucis! How do we feel about the fact that now we don't have all three buttons in one line anymore? I know it was a little "overwhelming" at the size the previews originally made it, but I did at least like having all those across in one line.

If we had a FOURTH way to open these... ooh, wait, Replit now works with Astro, eh? Let me experiment with that....

OK, that's not a quick thing right now. Scratch that for now. So, what's better? Larger cards with all the buttons making one line, or smaller cards with the wrapping buttons? Otherwise, #NWTWWHB ?!

@sarah11918
Copy link
Member Author

Loving the extra whitespace at the bottom. Gonna go with this, and we'll make a list of improvements we've discovered while doing this for further tasks! Thanks @delucis! 💜

@sarah11918 sarah11918 merged commit 104adf7 into main Sep 3, 2022
@sarah11918 sarah11918 deleted the image-previews branch September 3, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants