fix: added onError functionality to spinner (#9048)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

.changeset/silent-experts-sip.md

@@ -0,0 +1,5 @@
+---
+'create-astro': patch
+---
+
+Fixes an issue where a successful "Dependencies installed" message is displayed even when installing dependencies fails.

packages/create-astro/package.json

@@ -31,7 +31,7 @@
   "//a": "MOST PACKAGES SHOULD GO IN DEV_DEPENDENCIES! THEY WILL BE BUNDLED.",
   "//b": "DEPENDENCIES IS FOR UNBUNDLED PACKAGES",
   "dependencies": {
-    "@astrojs/cli-kit": "^0.3.0",
+    "@astrojs/cli-kit": "^0.3.1",
     "giget": "1.1.2"
   },
   "devDependencies": {

packages/create-astro/src/actions/dependencies.ts

@@ -27,17 +27,16 @@ export async function dependencies(
 		await spinner({
 			start: `Installing dependencies with ${ctx.packageManager}...`,
 			end: 'Dependencies installed',
-			while: () => {
-				return install({ packageManager: ctx.packageManager, cwd: ctx.cwd }).catch((e) => {
-					error('error', e);
-					error(
-						'error',
-						`Dependencies failed to install, please run ${color.bold(
-							ctx.packageManager + ' install'
-						)}  to install them manually after setup.`
-					);
-				});
+			onError: (e) => {
+				error('error', e);
+				error(
+					'error',
+					`Dependencies failed to install, please run ${color.bold(
+						ctx.packageManager + ' install'
+					)} to install them manually after setup.`
+				);
 			},
+			while: () => install({ packageManager: ctx.packageManager, cwd: ctx.cwd }),
 		});
 	} else {
 		await info(

packages/create-astro/src/messages.ts

@@ -31,6 +31,7 @@ export async function say(messages: string | string[], { clear = false, hat = ''
 export async function spinner(args: {
 	start: string;
 	end: string;
+	onError?: (error: any) => void;
 	while: (...args: any) => Promise<any>;
 }) {
 	await load(args, { stdout });