Skip to content

Commit

Permalink
fix(node): report render error to the terminal (#8599)
Browse files Browse the repository at this point in the history
  • Loading branch information
lilnasy authored Sep 20, 2023
1 parent 1f1c47d commit 2e1d5f8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/curly-icons-watch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/node': patch
---

The node adapter now logs uncaught errors encountered during rendering a page.
3 changes: 3 additions & 0 deletions packages/integrations/node/src/nodeMiddleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ export default function (app: NodeApp, mode: Options['mode']) {
await writeWebResponse(app, res, response);
}
} catch (err: unknown) {
const logger = app.getAdapterLogger()
logger.error(`Could not render ${req.url}`)
console.error(err)
if (!res.headersSent) {
res.writeHead(500, `Server error`);
res.end();
Expand Down

0 comments on commit 2e1d5f8

Please sign in to comment.