fix(audits): Don't warn about loading on data URIs (#10275)

withastro · Mar 1, 2024 · 5e3e74b · 5e3e74b
1 parent d5277df
commit 5e3e74b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/.changeset/warm-buttons-agree.md b/.changeset/warm-buttons-agree.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Fixes dev toolbar warning about using the proper loading attributes on images using `data:` URIs
diff --git a/packages/astro/src/runtime/client/dev-toolbar/apps/audit/perf.ts b/packages/astro/src/runtime/client/dev-toolbar/apps/audit/perf.ts
@@ -38,6 +38,9 @@ export const perf: AuditRuleWithSelector[] = [
 			// Ignore elements that are above the fold, they should be loaded eagerly
 			if (htmlElement.offsetTop < window.innerHeight) return false;
 
+			// Ignore elements using `data:` URI, the `loading` attribute doesn't do anything for these
+			if (htmlElement.src.startsWith('data:')) return false;
+
 			return true;
 		},
 	},
@@ -53,6 +56,9 @@ export const perf: AuditRuleWithSelector[] = [
 			// Ignore elements that are below the fold, they should be loaded lazily
 			if (htmlElement.offsetTop > window.innerHeight) return false;
 
+			// Ignore elements using `data:` URI, the `loading` attribute doesn't do anything for these
+			if (htmlElement.src.startsWith('data:')) return false;
+
 			return true;
 		},
 	},