Skip to content

Commit

Permalink
Resolve peer dependency problem in the integration packages (SolidJS,…
Browse files Browse the repository at this point in the history
… Vue, Svelte, React) (#12481)

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: ematipico <602478+ematipico@users.noreply.github.com>
Co-authored-by: bluwy <34116392+bluwy@users.noreply.github.com>
  • Loading branch information
4 people authored Nov 21, 2024
1 parent e329657 commit 8a46e80
Show file tree
Hide file tree
Showing 7 changed files with 37 additions and 24 deletions.
9 changes: 9 additions & 0 deletions .changeset/strong-stingrays-provide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@astrojs/solid-js': patch
'@astrojs/vue': patch
'@astrojs/svelte': patch
'@astrojs/react': patch
'@astrojs/preact': patch
---

Resolve `vite` peer dependency problem for strict package managers like **Yarn in PnP mode**.
3 changes: 2 additions & 1 deletion packages/integrations/preact/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
"@preact/preset-vite": "2.8.2",
"@preact/signals": "^1.3.0",
"babel-plugin-transform-hook-names": "^1.0.2",
"preact-render-to-string": "^6.5.11"
"preact-render-to-string": "^6.5.11",
"vite": "^5.4.10"
},
"devDependencies": {
"astro": "workspace:*",
Expand Down
6 changes: 3 additions & 3 deletions packages/integrations/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
},
"dependencies": {
"@vitejs/plugin-react": "^4.3.3",
"ultrahtml": "^1.5.3"
"ultrahtml": "^1.5.3",
"vite": "^5.4.10"
},
"devDependencies": {
"@types/react": "^18.3.12",
Expand All @@ -59,8 +60,7 @@
"astro-scripts": "workspace:*",
"cheerio": "1.0.0",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"vite": "^5.4.10"
"react-dom": "^18.3.1"
},
"peerDependencies": {
"@types/react": "^17.0.50 || ^18.0.21",
Expand Down
6 changes: 3 additions & 3 deletions packages/integrations/solid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@
"dev": "astro-scripts dev \"src/**/*.ts\""
},
"dependencies": {
"vite-plugin-solid": "^2.10.2"
"vite-plugin-solid": "^2.10.2",
"vite": "^5.4.10"
},
"devDependencies": {
"astro": "workspace:*",
"astro-scripts": "workspace:*",
"solid-js": "^1.9.3",
"vite": "^5.4.10"
"solid-js": "^1.9.3"
},
"peerDependencies": {
"solid-devtools": "^0.30.1",
Expand Down
6 changes: 3 additions & 3 deletions packages/integrations/svelte/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@
},
"dependencies": {
"@sveltejs/vite-plugin-svelte": "^4.0.0",
"svelte2tsx": "^0.7.22"
"svelte2tsx": "^0.7.22",
"vite": "^5.4.10"
},
"devDependencies": {
"astro": "workspace:*",
"astro-scripts": "workspace:*",
"svelte": "^5.1.16",
"vite": "^5.4.10"
"svelte": "^5.1.16"
},
"peerDependencies": {
"astro": "^4.0.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/integrations/vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@
"@vitejs/plugin-vue": "^5.1.4",
"@vitejs/plugin-vue-jsx": "^4.0.1",
"@vue/compiler-sfc": "^3.5.12",
"vite-plugin-vue-devtools": "^7.6.3"
"vite-plugin-vue-devtools": "^7.6.3",
"vite": "^5.4.10"
},
"devDependencies": {
"astro": "workspace:*",
"astro-scripts": "workspace:*",
"cheerio": "1.0.0",
"linkedom": "^0.18.5",
"vite": "^5.4.10",
"vue": "^3.5.12"
},
"peerDependencies": {
Expand Down
27 changes: 15 additions & 12 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8a46e80

Please sign in to comment.