config: use moduleResolution node16

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "typescript.preferences.importModuleSpecifierEnding": "js"
+}

packages/astro-rss/src/util.ts

@@ -1,5 +1,5 @@
 import type { z } from 'astro/zod';
-import type { RSSOptions } from './index';
+import type { RSSOptions } from './index.js';
 
 /** Normalize URL to its canonical form */
 export function createCanonicalURL(

packages/astro/client-base.d.ts

@@ -57,7 +57,7 @@ declare module 'astro:assets' {
 	type WithRequired<T, K extends keyof T> = T & { [P in K]-?: T[P] };
 	type Simplify<T> = { [KeyType in keyof T]: T[KeyType] };
 	type ImgAttributes = WithRequired<
-		Omit<import('./types').HTMLAttributes<'img'>, 'src' | 'width' | 'height'>,
+		Omit<import('./types.js').HTMLAttributes<'img'>, 'src' | 'width' | 'height'>,
 		'alt'
 	>;
 
@@ -79,7 +79,7 @@ declare module 'astro:transitions' {
 	export const ViewTransitions: ViewTransitionsModule['default'];
 }
 
-type MD = import('./dist/@types/astro').MarkdownInstance<Record<string, any>>;
+type MD = import('./dist/@types/astro.js').MarkdownInstance<Record<string, any>>;
 interface ExportedMarkdownModuleEntities {
 	frontmatter: MD['frontmatter'];
 	file: MD['file'];
@@ -184,7 +184,7 @@ declare module '*.mdown' {
 }
 
 declare module '*.mdx' {
-	type MDX = import('./dist/@types/astro').MDXInstance<Record<string, any>>;
+	type MDX = import('./dist/@types/astro.js').MDXInstance<Record<string, any>>;
 
 	export const frontmatter: MDX['frontmatter'];
 	export const file: MDX['file'];
@@ -197,7 +197,7 @@ declare module '*.mdx' {
 }
 
 declare module 'astro:ssr-manifest' {
-	export const manifest: import('./dist/@types/astro').SSRManifest;
+	export const manifest: import('./dist/@types/astro.js').SSRManifest;
 }
 
 // Everything below are Vite's types (apart from image types, which are in `client.d.ts`)

packages/astro/package.json

@@ -150,7 +150,7 @@
     "html-escaper": "^3.0.3",
     "js-yaml": "^4.1.0",
     "kleur": "^4.1.4",
-    "magic-string": "^0.27.0",
+    "magic-string": "^0.30.1",
     "mime": "^3.0.0",
     "network-information-types": "^0.1.1",
     "ora": "^6.3.1",

packages/astro/src/@types/astro.ts

@@ -14,13 +14,13 @@ import type * as rollup from 'rollup';
 import type { TsConfigJson } from 'tsconfig-resolver';
 import type * as vite from 'vite';
 import type { z } from 'zod';
-import type { SerializedSSRManifest } from '../core/app/types';
-import type { PageBuildData } from '../core/build/types';
-import type { AstroConfigSchema } from '../core/config';
-import type { AstroTimer } from '../core/config/timer';
-import type { AstroCookies } from '../core/cookies';
-import type { LogOptions } from '../core/logger/core';
-import type { AstroComponentFactory, AstroComponentInstance } from '../runtime/server';
+import type { SerializedSSRManifest } from '../core/app/types.js';
+import type { PageBuildData } from '../core/build/types.js';
+import type { AstroConfigSchema } from '../core/config/index.js';
+import type { AstroTimer } from '../core/config/timer.js';
+import type { AstroCookies } from '../core/cookies/index.js';
+import type { LogOptions } from '../core/logger/core.js';
+import type { AstroComponentFactory, AstroComponentInstance } from '../runtime/server/index.js';
 import type { SUPPORTED_MARKDOWN_FILE_EXTENSIONS } from './../core/constants.js';
 export type {
 	MarkdownHeading,
@@ -34,7 +34,7 @@ export type {
 	ExternalImageService,
 	ImageService,
 	LocalImageService,
-} from '../assets/services/service';
+} from '../assets/services/service.js';
 export type {
 	GetImageResult,
 	ImageInputFormat,
@@ -43,9 +43,9 @@ export type {
 	ImageQuality,
 	ImageQualityPreset,
 	ImageTransform,
-} from '../assets/types';
-export type { SSRManifest } from '../core/app/types';
-export type { AstroCookies } from '../core/cookies';
+} from '../assets/types.js';
+export type { SSRManifest } from '../core/app/types.js';
+export type { AstroCookies } from '../core/cookies/index.js';
 
 export interface AstroBuiltinProps {
 	'client:load'?: boolean;

packages/astro/src/assets/services/vendor/squoosh/codecs.ts

@@ -33,23 +33,23 @@ export interface RotateOptions {
 }
 
 // MozJPEG
-import type { MozJPEGModule as MozJPEGEncodeModule } from './mozjpeg/mozjpeg_enc'
+import type { MozJPEGModule as MozJPEGEncodeModule } from './mozjpeg/mozjpeg_enc.js'
 import mozDec from './mozjpeg/mozjpeg_node_dec.js'
 import mozDecWasm from './mozjpeg/mozjpeg_node_dec.wasm.js'
 
 import mozEnc from './mozjpeg/mozjpeg_node_enc.js'
 import mozEncWasm from './mozjpeg/mozjpeg_node_enc.wasm.js'
 
 // WebP
-import type { WebPModule as WebPEncodeModule } from './webp/webp_enc'
+import type { WebPModule as WebPEncodeModule } from './webp/webp_enc.js'
 import webpDec from './webp/webp_node_dec.js'
 import webpDecWasm from './webp/webp_node_dec.wasm.js'
 
 import webpEnc from './webp/webp_node_enc.js'
 import webpEncWasm from './webp/webp_node_enc.wasm.js'
 
 // AVIF
-import type { AVIFModule as AVIFEncodeModule } from './avif/avif_enc'
+import type { AVIFModule as AVIFEncodeModule } from './avif/avif_enc.js'
 import avifDec from './avif/avif_node_dec.js'
 import avifDecWasm from './avif/avif_node_dec.wasm.js'
 

packages/astro/src/assets/vendor/image-size/types/bmp.ts

@@ -1,4 +1,4 @@
-import type { IImage } from './interface'
+import type { IImage } from './interface.js'
 
 export const BMP: IImage = {
   validate(buffer) {

packages/astro/src/assets/vendor/image-size/types/cur.ts

@@ -1,5 +1,5 @@
 import { ICO } from './ico.js'
-import type { IImage } from './interface'
+import type { IImage } from './interface.js'
 
 const TYPE_CURSOR = 2
 export const CUR: IImage = {

packages/astro/src/assets/vendor/image-size/types/dds.ts

@@ -1,4 +1,4 @@
-import type { IImage } from './interface'
+import type { IImage } from './interface.js'
 
 export const DDS: IImage = {
   validate(buffer) {

packages/astro/src/assets/vendor/image-size/types/gif.ts

@@ -1,4 +1,4 @@
-import type { IImage } from './interface'
+import type { IImage } from './interface.js'
 
 const gifRegexp = /^GIF8[79]a/
 export const GIF: IImage = {

packages/astro/src/assets/vendor/image-size/types/icns.ts

@@ -1,4 +1,4 @@
-import type { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface.js'
 
 /**
  * ICNS Header

packages/astro/src/assets/vendor/image-size/types/ico.ts

@@ -1,4 +1,4 @@
-import type { IImage, ISize, ISizeCalculationResult } from './interface'
+import type { IImage, ISize, ISizeCalculationResult } from './interface.js'
 
 const TYPE_ICON = 1
 

packages/astro/src/assets/vendor/image-size/types/j2c.ts

@@ -1,4 +1,4 @@
-import type { IImage } from './interface'
+import type { IImage } from './interface.js'
 
 export const J2C: IImage = {
   validate(buffer) {

packages/astro/src/assets/vendor/image-size/types/jp2.ts

@@ -1,4 +1,4 @@
-import type { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface.js'
 
 const BoxTypes = {
   ftyp: '66747970',

packages/astro/src/assets/vendor/image-size/types/jpg.ts

@@ -4,7 +4,7 @@
 // if this range we can't detect the file size correctly.
 
 import { readUInt } from '../readUInt.js'
-import type { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface.js'
 
 const EXIF_MARKER = '45786966'
 const APP1_DATA_SIZE_BYTES = 2

packages/astro/src/assets/vendor/image-size/types/ktx.ts

@@ -1,4 +1,4 @@
-import type { IImage } from './interface'
+import type { IImage } from './interface.js'
 
 const SIGNATURE = 'KTX 11'
 

packages/astro/src/assets/vendor/image-size/types/png.ts

@@ -1,4 +1,4 @@
-import type { IImage } from './interface'
+import type { IImage } from './interface.js'
 
 const pngSignature = 'PNG\r\n\x1a\n'
 const pngImageHeaderChunkName = 'IHDR'

packages/astro/src/assets/vendor/image-size/types/pnm.ts

@@ -1,4 +1,4 @@
-import type { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface.js'
 
 const PNMTypes: { [signature: string]: string } = {
   P1: 'pbm/ascii',

packages/astro/src/assets/vendor/image-size/types/psd.ts

@@ -1,4 +1,4 @@
-import type { IImage } from './interface'
+import type { IImage } from './interface.js'
 
 export const PSD: IImage = {
   validate(buffer) {

packages/astro/src/assets/vendor/image-size/types/svg.ts

@@ -1,4 +1,4 @@
-import type { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface.js'
 
 interface IAttributes {
   width: number | null

packages/astro/src/assets/vendor/image-size/types/tiff.ts

@@ -2,7 +2,7 @@
 // TO-DO: support big-endian as well
 import * as fs from 'node:fs'
 import { readUInt } from '../readUInt.js'
-import type { IImage } from './interface'
+import type { IImage } from './interface.js'
 
 // Read IFD (image-file-directory) into a buffer
 function readIFD(buffer: Buffer, filepath: string, isBigEndian: boolean) {

packages/astro/src/assets/vendor/image-size/types/webp.ts

@@ -1,5 +1,5 @@
 // based on https://developers.google.com/speed/webp/docs/riff_container
-import type { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface.js'
 
 function calculateExtended(buffer: Buffer): ISize {
   return {

packages/astro/src/assets/vite-plugin-assets.ts

@@ -3,7 +3,7 @@ import MagicString from 'magic-string';
 import { fileURLToPath } from 'node:url';
 import type * as vite from 'vite';
 import { normalizePath } from 'vite';
-import type { AstroPluginOptions, ImageTransform } from '../@types/astro';
+import type { AstroPluginOptions, ImageTransform } from '../@types/astro.js';
 import { error } from '../core/logger/core.js';
 import {
 	appendForwardSlash,

packages/astro/src/cli/add/babel.ts

@@ -3,13 +3,11 @@ import parser from '@babel/parser';
 import traverse from '@babel/traverse';
 import * as t from '@babel/types';
 
-// @ts-expect-error @babel/traverse isn't ESM and needs this trick
-export const visit = traverse.default as typeof traverse;
+export const visit = traverse.default;
 export { t };
 
 export async function generate(ast: t.File) {
-	// @ts-expect-error @babel/generator isn't ESM and needs this trick
-	const astToText = generator.default as typeof generator;
+	const astToText = generator.default;
 	const { code } = astToText(ast);
 	return code;
 }

packages/astro/src/cli/check/index.ts

@@ -12,11 +12,11 @@ import { join } from 'node:path';
 import { fileURLToPath, pathToFileURL } from 'node:url';
 import ora from 'ora';
 import type { Arguments as Flags } from 'yargs-parser';
-import type { AstroSettings } from '../../@types/astro';
+import type { AstroSettings } from '../../@types/astro.js';
 import type { LogOptions } from '../../core/logger/core.js';
 import { debug, info } from '../../core/logger/core.js';
 import { printHelp } from '../../core/messages.js';
-import type { ProcessExit, SyncOptions } from '../../core/sync';
+import type { ProcessExit, SyncOptions } from '../../core/sync/index.js';
 import { loadSettings } from '../load-settings.js';
 import { printDiagnostic } from './print.js';
 

packages/astro/src/config/index.ts

@@ -1,6 +1,6 @@
 import type { UserConfig } from 'vite';
-import type { AstroUserConfig } from '../@types/astro';
-import type { LogOptions } from '../core/logger/core';
+import type { AstroUserConfig } from '../@types/astro.js';
+import type { LogOptions } from '../core/logger/core.js';
 
 export function defineConfig(config: AstroUserConfig) {
 	return config;

packages/astro/src/config/vite-plugin-content-listen.ts

@@ -1,6 +1,6 @@
 import type fsMod from 'node:fs';
 import type { Plugin, ViteDevServer } from 'vite';
-import type { AstroSettings } from '../@types/astro';
+import type { AstroSettings } from '../@types/astro.js';
 import { attachContentServerListeners } from '../content/server-listeners.js';
 import type { LogOptions } from '../core/logger/core.js';
 

packages/astro/src/content/vite-plugin-content-assets.ts

@@ -5,7 +5,7 @@ import type { AstroSettings } from '../@types/astro.js';
 import { moduleIsTopLevelPage, walkParentInfos } from '../core/build/graph.js';
 import { getPageDataByViteID, type BuildInternals } from '../core/build/internal.js';
 import type { AstroBuildPlugin } from '../core/build/plugin.js';
-import type { StaticBuildOptions } from '../core/build/types';
+import type { StaticBuildOptions } from '../core/build/types.js';
 import type { ModuleLoader } from '../core/module-loader/loader.js';
 import { createViteLoader } from '../core/module-loader/vite.js';
 import { joinPaths, prependForwardSlash } from '../core/path.js';

packages/astro/src/core/app/common.ts

@@ -1,5 +1,5 @@
 import { deserializeRouteData } from '../routing/manifest/serialization.js';
-import type { RouteInfo, SerializedSSRManifest, SSRManifest } from './types';
+import type { RouteInfo, SerializedSSRManifest, SSRManifest } from './types.js';
 
 export function deserializeManifest(serializedManifest: SerializedSSRManifest): SSRManifest {
 	const routes: RouteInfo[] = [];

packages/astro/src/core/app/index.ts

@@ -5,14 +5,14 @@ import type {
 	RouteData,
 	SSRElement,
 	SSRManifest,
-} from '../../@types/astro';
-import type { SinglePageBuiltModule } from '../build/types';
+} from '../../@types/astro.js';
+import type { SinglePageBuiltModule } from '../build/types.js';
 import { attachToResponse, getSetCookiesFromResponse } from '../cookies/index.js';
 import { consoleLogDestination } from '../logger/console.js';
 import { error, type LogOptions } from '../logger/core.js';
 import { prependForwardSlash, removeTrailingForwardSlash } from '../path.js';
 import { RedirectSinglePageBuiltModule } from '../redirects/index.js';
-import { isResponse } from '../render/core';
+import { isResponse } from '../render/core.js';
 import {
 	createEnvironment,
 	createRenderContext,
@@ -27,7 +27,7 @@ import {
 	createStylesheetElementSet,
 } from '../render/ssr-element.js';
 import { matchRoute } from '../routing/match.js';
-import type { RouteInfo } from './types';
+import type { RouteInfo } from './types.js';
 export { deserializeManifest } from './common.js';
 
 const clientLocalsSymbol = Symbol.for('astro.locals');

packages/astro/src/core/app/node.ts

@@ -1,5 +1,5 @@
-import type { RouteData } from '../../@types/astro';
-import type { SerializedSSRManifest, SSRManifest } from './types';
+import type { RouteData } from '../../@types/astro.js';
+import type { SerializedSSRManifest, SSRManifest } from './types.js';
 
 import * as fs from 'node:fs';
 import { IncomingMessage } from 'node:http';

packages/astro/src/core/app/types.ts

@@ -5,8 +5,8 @@ import type {
 	SSRComponentMetadata,
 	SSRLoadedRenderer,
 	SSRResult,
-} from '../../@types/astro';
-import type { SinglePageBuiltModule } from '../build/types';
+} from '../../@types/astro.js';
+import type { SinglePageBuiltModule } from '../build/types.js';
 
 export type ComponentPath = string;
 

packages/astro/src/core/build/common.ts

@@ -1,6 +1,6 @@
 import npath from 'node:path';
 import { fileURLToPath, pathToFileURL } from 'node:url';
-import type { AstroConfig, RouteType } from '../../@types/astro';
+import type { AstroConfig, RouteType } from '../../@types/astro.js';
 import { appendForwardSlash } from '../../core/path.js';
 
 const STATUS_CODE_PAGES = new Set(['/404', '/500']);

packages/astro/src/core/build/css-asset-name.ts

@@ -2,7 +2,7 @@ import type { GetModuleInfo } from 'rollup';
 
 import crypto from 'node:crypto';
 import npath from 'node:path';
-import type { AstroSettings } from '../../@types/astro';
+import type { AstroSettings } from '../../@types/astro.js';
 import { viteID } from '../util.js';
 import { getTopLevelPages } from './graph.js';
 

packages/astro/src/core/build/generate.ts

@@ -15,7 +15,7 @@ import type {
 	SSRError,
 	SSRLoadedRenderer,
 	SSRManifest,
-} from '../../@types/astro';
+} from '../../@types/astro.js';
 import {
 	generateImage as generateImageInternal,
 	getStaticImageList,
@@ -61,7 +61,7 @@ import type {
 	SinglePageBuiltModule,
 	StaticBuildOptions,
 	StylesheetAsset,
-} from './types';
+} from './types.js';
 import { getTimeStat } from './util.js';
 
 function createEntryURL(filePath: string, outFolder: URL) {

packages/astro/src/core/build/index.ts

@@ -3,7 +3,7 @@ import fs from 'node:fs';
 import { performance } from 'node:perf_hooks';
 import type * as vite from 'vite';
 import type yargs from 'yargs-parser';
-import type { AstroConfig, AstroSettings, ManifestData, RuntimeMode } from '../../@types/astro';
+import type { AstroConfig, AstroSettings, ManifestData, RuntimeMode } from '../../@types/astro.js';
 import {
 	runHookBuildDone,
 	runHookBuildStart,