Skip to content

Commit

Permalink
Fix: (patching old PR) Check node version and find acceptable host ac…
Browse files Browse the repository at this point in the history
…cordingly (#4032)

* fix: check node version and find acceptable host accordingly

* Update for Node v18.4+

* Removed unrelated changesets

* Revert "Removed unrelated changesets"

This reverts commit e77ffc0.

* chore: remove duplicate changeset

Co-authored-by: Nate Moore <nate@astro.build>
  • Loading branch information
arimgibson and natemoo-re authored Jul 23, 2022
1 parent 8c08181 commit beddf07
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/strange-needles-hide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fix: find a hosting network differently based on Node version -- adjusted for Node v18.4+
3 changes: 2 additions & 1 deletion packages/astro/src/core/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,13 @@ export function devStart({
if (networkLogging === 'host-to-expose') {
network = `${networkPrefix}${dim('use --host to expose')}`;
} else if (networkLogging === 'visible') {
const nodeVersion = Number(process.version.substring(1, process.version.indexOf(".", 5)));
const ipv4Networks = Object.values(os.networkInterfaces())
.flatMap((networkInterface) => networkInterface ?? [])
.filter(
(networkInterface) =>
networkInterface?.address &&
networkInterface?.family === (Number(process.version.substring(1, 5)) < 18.1 ? 'IPv4' : 4)
networkInterface?.family === ((nodeVersion < 18 || nodeVersion >= 18.4) ? 'IPv4' : 4)
);
for (let { address } of ipv4Networks) {
if (address.includes('127.0.0.1')) {
Expand Down

0 comments on commit beddf07

Please sign in to comment.