Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❓ Improve compileExpressionSafe error messages #455

Closed
1 of 3 tasks
natemoo-re opened this issue Jun 15, 2021 · 0 comments · Fixed by #476
Closed
1 of 3 tasks

❓ Improve compileExpressionSafe error messages #455

natemoo-re opened this issue Jun 15, 2021 · 0 comments · Fixed by #476
Assignees
@natemoo-re

Comments

@natemoo-re
Copy link
Member

What is Missing from Astro Today?

JSX expressions are compiled with esbuild, but we're not surfacing esbuild errors. Users just get a generic error.

Proposed Solution

We should surface those and map them back to the code frame where they're thrown.

Help Make it Happen!

  • I am willing to submit a PR to implement this change.
  • I am willing to submit a PR to implement this change, but would need some guidance.
  • I am not willing to submit a PR to implement this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natemoo-re natemoo-re

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#455): improve error logging inside of expressions withastro/astro
1 participant
@natemoo-re