Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I updated from v2 to V3 and now I get error when i do npm run dev #8434

Closed
1 task
Thebuilderekes opened this issue Sep 6, 2023 · 8 comments · Fixed by #8440
Closed
1 task

I updated from v2 to V3 and now I get error when i do npm run dev #8434

Thebuilderekes opened this issue Sep 6, 2023 · 8 comments · Fixed by #8440
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)

Comments

@Thebuilderekes
Copy link

Thebuilderekes commented Sep 6, 2023

Astro Info

Astro                    v3.0.9
Node                     v18.17.1
System                   Linux (x64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             @astrojs/react
                         @astrojs/tailwind

If this issue only occurs in one browser, which browser is a problem?

chrome

Describe the Bug

I updated from v2 to V3 and now I get this error when I use npm run dev. Now using node v18.17.1 (npm v10.0.0) Deleted and node modules folder and package-lock.json and used npm install while switching between versions 20.5.1, 18.14.1, 18.17.1 and still got the same error.
astro2

What's the expected result?

I expect that the website shows up on localhost:4321

Link to Minimal Reproducible Example

--

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Sep 6, 2023
@lilnasy lilnasy added the needs repro Issue needs a reproduction label Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Hello @Thebuilderekes. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs repro will be closed if they have no activity within 3 days.

@github-actions github-actions bot removed the needs triage Issue needs to be triaged label Sep 6, 2023
@Thebuilderekes Thebuilderekes changed the title I get error when i do npm run dev I updated from v2 to V3 and now I get error when i do npm run dev Sep 6, 2023
@matthewp
Copy link
Contributor

matthewp commented Sep 6, 2023

I'd say it's likely you have some dependencies that are not updated. We will need some more information to help further, however.

@teinett
Copy link

teinett commented Sep 6, 2023

I have the same issue. I updated from 3.0.7 today to 3.0.9 and got this:

Снимок экрана 2023-09-06 в 12 36 22

@natemoo-re
Copy link
Member

If anyone is able to attach a reproduction using https://astro.new/minimal that would significantly speed up our debugging process!

@natemoo-re natemoo-re added the - P4: important Violate documented behavior or significantly impacts performance (priority) label Sep 6, 2023
@teinett
Copy link

teinett commented Sep 6, 2023

My repo with the small project: https://github.com/teinett/learn-astro-images

@natemoo-re
Copy link
Member

natemoo-re commented Sep 6, 2023

Looks like this is the code that is throwing.

// Render all children eagerly and in parallel
const childRenders = child.map((c) => {
return renderToBufferDestination((bufferDestination) => {
return renderChild(bufferDestination, c);
});
});
for (const childRender of childRenders) {
await childRender.renderToFinalDestination(destination);
}

@natemoo-re
Copy link
Member

Thanks @teinett! I'm taking a look right now.

@natemoo-re
Copy link
Member

Will be fixed by #8440

@natemoo-re natemoo-re removed the needs repro Issue needs a reproduction label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants