ReadableStream in response body not canceled when client closes connection

[pilcrowonpaper]

Astro Info

Astro                    v3.5.2
Node                     v20.2.0
System                   macOS (x64)
Package Manager          pnpm
Output                   server
Adapter                  @astrojs/node
Integrations             @astrojs/tailwind

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When implementing server-sent events, cancel() is not called when client closes the connection (e.g. closes the tab).

export async function GET() {
  const stream = new ReadableStream({
    start(controller) {
      // do stuff
    },
    cancel() {
      console.log("cancelled");
    },
  });
  return new Response(stream, {
    headers: {
      "X-Content-Type-Options": "nosniff",
      "Content-Type": "text/event-stream; charset=utf-8",
      "Transfer-Encoding": "chunked",
    },
  });
}

What's the expected result?

cancelled is logged to the console

Link to Minimal Reproducible Example

https://github.com/pilcrowOnPaper/astro-readable-stream-bug

Participation

• I am willing to submit a pull request for this issue.

[pilcrowonpaper]

I don't think I know enough about the code base to make a PR, but fix would look something like this:

const reader = await webResponse.body.getReader();
res.on("close", () => {
   reader.cancel();
})
let result = await reader.read();
while (!result.done) {
   res.write(result.value);
   result = await reader.read();
}

[tarekwiz]

@lilnasy This doesn't work on dev. Only after build.

[ruohki]

@lilnasy This doesn't work on dev. Only after build.

THIS IS SUCH A BANGER INFO ... I've been pulling my hair out about this.