Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix failing tests and skip some #10141

Merged
merged 1 commit into from
Feb 16, 2024
Merged

chore: fix failing tests and skip some #10141

merged 1 commit into from
Feb 16, 2024

Conversation

ematipico
Copy link
Member

Changes

This PR does the following:

  • fixes a bunch of issues caused by the content collection tests. The .clean() function that was called in the after hook is async, but it was called without an await causing all the next test cases to fail the build because a clean up was in progress cc @florian-lefebvre
  • there were some issues in some other tests. I will have to ping people internally to figure out why the are failing now. The hydration test seems legitimate. The errors test is weird, I wonder if it's some kind of regression cc @lilnasy

Testing

The CI should pass

Docs

Copy link

changeset-bot bot commented Feb 16, 2024

⚠️ No Changeset found

Latest commit: b1b4399

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Feb 16, 2024
@ematipico
Copy link
Member Author

I am going to merge this because I still have work to do, and I need this PR. Feel free to add any comments for context.

@ematipico ematipico merged commit 2351c5e into main Feb 16, 2024
13 checks passed
@ematipico ematipico deleted the chore/fix-skip-tests branch February 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant