Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where Vercel adapter may create functions for prerendered routes #10231

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Fix an issue where Vercel adapter may create functions for prerendered routes #10231

merged 5 commits into from
Feb 26, 2024

Conversation

mingjunlu
Copy link
Contributor

Changes

Testing

  • Test cases updated

Docs

  • N/A

Copy link

changeset-bot bot commented Feb 26, 2024

🦋 Changeset detected

Latest commit: 8b71d4f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 26, 2024
@ematipico ematipico requested a review from lilnasy February 26, 2024 11:18
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for the clear tests as well.

@lilnasy lilnasy merged commit ae2a10e into withastro:main Feb 26, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 26, 2024
@mingjunlu mingjunlu deleted the fix/vercel-function-per-route branch February 26, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vercel adapter: parameter "functionPerRoute" generate serverless function even for prerendered routes
3 participants