-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed an error in the vue component editor(https://github.com/wi… #10283
Conversation
|
Awesome, thank you! Would it be possible to add tests? Essentially, add a new |
I have already added it and verified it myself in the editor without any problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new tests use an assertion library that we don't use anymore.
@@ -49,6 +49,7 @@ | |||
"@types/chai": "^4.3.10", | |||
"astro": "workspace:*", | |||
"astro-scripts": "workspace:*", | |||
"chai": "^4.3.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use chai
anymore, you'll have to use node:assert/strict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to revert this file too @phk422
…thastro/language-tools/issues/758)
Changes
defineProps