Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reference base types #10315

Merged
merged 3 commits into from
Mar 4, 2024
Merged

fix: reference base types #10315

merged 3 commits into from
Mar 4, 2024

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Update db package to reference base index.d.ts to ensure astro:db is defined.

Testing

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8e081f1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

delucis
delucis approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bholmesdev bholmesdev merged commit 78ddfad into main Mar 4, 2024
13 checks passed
@bholmesdev bholmesdev deleted the fix/db-types branch March 4, 2024 14:14
@astrobot-houston astrobot-houston mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@ematipico ematipico ematipico approved these changes

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bholmesdev @delucis @ematipico @bluwy