Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where getCollection might return undefined #10356

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fix an issue where getCollection might return undefined #10356

merged 2 commits into from
Mar 7, 2024

Conversation

mingjunlu
Copy link
Contributor

Changes

Testing

  • A related test case in packages/astro/test/content-collections.test.js is updated

Docs

  • N/A

Copy link

changeset-bot bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: 0b69abf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 7, 2024
@mingjunlu mingjunlu changed the title Fix an issue where getCollection might return undefined when content collection is empty Fix an issue where getCollection might return undefined Mar 7, 2024
@ematipico ematipico merged commit d121311 into withastro:main Mar 7, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Mar 7, 2024
@mingjunlu mingjunlu deleted the fix/get-collection-returning-undefined branch March 7, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getCollection types are wrong and should never return underfined
2 participants