-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batch support #10361
Add batch support #10361
Conversation
🦋 Changeset detectedLatest commit: 0f02294 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
48217da
to
0ec7857
Compare
!preview db-batch |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not familiar with the code, so hard to review, but left one question.
In the PR description docs says “N/A” but if this is something we support, wouldn’t we need to document it?
@delucis re-documentation: I'm using Sarah's suggestion to outsource to the Drizzle docs as much as possible to avoid explaining all of their features. There is an argument to document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using Sarah's suggestion to outsource to the Drizzle docs
Ah, OK — assumed as we were adding support, there might be something Astro-specific to the API separate from Drizzle’s batch API. If that’s not the case, then all’s good!
Approving from a place of ignorance — a batch
made in heaven 🙌
Changes
Add support for
db.batch()
to run multiple queries in a single transaction.Testing
db.batch()
call to basics test fixtureDocs
N/A