fix(rendering): allow framework renders to be cancelled #10448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dd66cdf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
lilnasy
commented
Mar 14, 2024
lilnasy
commented
Mar 14, 2024
|
|
||
| describe('Streaming', () => { | ||
| if (isWindows) return; |
There was a problem hiding this comment.
The test suite passes on windows. Was there another reason these were skipped?
There was a problem hiding this comment.
No idea, to be honest. But if it passes, happy days!
ematipico
approved these changes
Mar 15, 2024
bluwy
approved these changes
Mar 18, 2024
Comment on lines
+487
to
+490
| function handleCancellation(e: unknown) { | ||
| if (result.cancelled) return { render() {} }; | ||
| throw e; | ||
| } |
There was a problem hiding this comment.
I was thinking we can wrap this entire function body with a try..catch, but this also works for me.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
renderTemplate()did not complete - an error was thrown before we could get references to the expressions.renderComponent()allowed us to get a reference the promise that would reject, and we could handle it.Testing
node --test test/streaming.test.js.Docs