fix(node): handle offshoot promise rejections #10454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 328cf34 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
lilnasy
changed the title
ematipico
approved these changes
Mar 15, 2024
bluwy
approved these changes
Mar 18, 2024
That's fair. I think it makes sense for the adapter to do it because there is no natural place for the developer to add the listener - api route top-level, middleware top-level? |
Merged
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
* fix(node): handle offshoot promise rejections * add test * add changeset * Update packages/integrations/node/test/errors.test.js
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
* fix(node): handle offshoot promise rejections * add test * add changeset * Update packages/integrations/node/test/errors.test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs