Prevent importing db core from db runtime #10568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7dfe091 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bholmesdev
reviewed
Mar 26, 2024
| export const EXEC_DEFAULT_EXPORT_ERROR = (fileName: string) => { | ||
| return EXEC_ERROR(`Missing default function export in ${bold(fileName)}`); | ||
| }; | ||
|
|
||
| export const REFERENCE_DNE_ERROR = (columnName: string) => { |
There was a problem hiding this comment.
Nit: maybe we can move errors.ts to the base of the src directory instead of splitting into two modules?
There was a problem hiding this comment.
We definitely can, it's interesting though that none of the errors are shared between. in which case, why have them together?
There was a problem hiding this comment.
Huh, honestly expected at least one to be shared. Guess we can keep separate if that's the case!
bholmesdev
approved these changes
Mar 26, 2024
ematipico
approved these changes
Mar 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
src/corefromsrc/runtimewill cause production to include rollup, vite and other unwanted things.Testing
Docs
N/A, bug fix