refactor: Drop Preact compat hack, remove incorrect alias #10585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6644c1e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: preact
lilnasy
reviewed
Mar 27, 2024
matthewp
approved these changes
Mar 28, 2024
bluwy
reviewed
Apr 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
preact/compataliases now that@preact/preset-vitesupports this natively (feat: Allow users to opt out of compat aliases preactjs/preset-vite#79)react/jsx-runtime->preact/jsx-runtimealias.@preact/preset-vitealready covers this (correctly) and so it did not need a replacement here.Testing
No functional changes, beyond fixing a theoretical edge case with the
jsx-runtimealias. I don't think it's worth adding a test here, this is pretty unlikely behavior to run across and is addressed by@preact/preset-vitealready.Docs
N/A, not user facing.
Misc
Some of the other config bits looks to be something we can upstream, so I'll take a look soon-ish and see if we can't reduce the config here further.