Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ssr external for vue #10601

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Remove the ssr external for vue #10601

merged 4 commits into from
Mar 29, 2024

Conversation

kalepail
Copy link
Contributor

Changes

Testing

Tested the CF Pages deploy and it works now.

Docs

Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: 248b1ea

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) labels Mar 29, 2024
@alexanderniebuhr
Copy link
Member

I'm not 100% sure where this should be landed. Either here or in the adapters PR 🤔
Any other opinions?

@ematipico
Copy link
Member

I'm not 100% sure where this should be landed. Either here or in the adapters PR 🤔 Any other opinions?

Why was '@vue/server-renderer' there in the first place? That's the question we should answer first. For the time being, I would land the PR in the clouldflare adapter, and investigate other adapters before landing this PR.

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm packages are external by default, so this is probably a remnant from before that was the case. Seems safe to do, to me.

@kalepail
Copy link
Contributor Author

fwiw this package is deprecated anyway as it's now included natively in the Vue package itself. (See https://www.npmjs.com/package/@vue/server-renderer)

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @kalepail can you please create a changeset?

@kalepail
Copy link
Contributor Author

@ematipico done...I think...first time committing a changeset

@ematipico ematipico merged commit b3028ca into withastro:main Mar 29, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants