-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the ssr external for vue #10601
Conversation
🦋 Changeset detectedLatest commit: 248b1ea The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I'm not 100% sure where this should be landed. Either here or in the adapters PR 🤔 |
Why was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm packages are external by default, so this is probably a remnant from before that was the case. Seems safe to do, to me.
fwiw this package is deprecated anyway as it's now included natively in the Vue package itself. (See https://www.npmjs.com/package/@vue/server-renderer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @kalepail can you please create a changeset?
@ematipico done...I think...first time committing a changeset |
Changes
Solves Deploying to CF Pages with a Vue Island is broken adapters#207
Testing
Tested the CF Pages deploy and it works now.
Docs