Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generator.ts to allow %23 (#) in dynamic urls #10965

Merged
merged 11 commits into from
May 16, 2024
Merged

Update generator.ts to allow %23 (#) in dynamic urls #10965

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9857ac8
Update generator.ts to allow %23 (#) in dynamic urls
Elias-Chairi May 7, 2024
77b6f20
added changeset
May 7, 2024
dfcdfcd
fix: Update generator.ts to santize url params as well
May 13, 2024
3c6da57
fix: sanitizeParams function
May 13, 2024
029f594
removed old fix
May 13, 2024
087b93d
fix: added test for decoded # and ?
May 13, 2024
d65c4c9
fix: formatting of file
May 13, 2024
a134819
sperated sanitizing of generated paths and ssr dynamic paths
May 13, 2024
7f0f9b7
refactor: using map instead
May 14, 2024
50e1c8b
Update .changeset/mean-geckos-sell.md
Elias-Chairi May 14, 2024
059b9f6
doc: added JSDoc for sanitizeParams function
May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mean-geckos-sell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": minor
Elias-Chairi marked this conversation as resolved.
Show resolved Hide resolved
---

Update generator.ts to allow %23 (#) in dynamic urls
2 changes: 1 addition & 1 deletion packages/astro/src/core/routing/manifest/generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function getRouteGenerator(
if (addTrailingSlash === 'always' && segments.length) {
trailing = '/';
}
const toPath = compile(template + trailing);
const toPath = compile(template + trailing, { delimiter: "/?" });
return (params: object): string => {
const path = toPath(params);

Expand Down
Loading