Convert saved non-UTC dates to UTC #10967
Conversation
🦋 Changeset detectedLatest commit: ae2e831 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/db/src/runtime/index.ts
Outdated
| if(!isISODateString(value)) { | ||
| // values saved using CURRENT_TIMESTAMP are not valid ISO strings | ||
| // but *are* in UTC, so append the UTC zone. | ||
| value += '.000Z'; |
There was a problem hiding this comment.
Did a quick tests and += 'Z' is actually all it takes — the milliseconds are irrelevant fwiw.
packages/db/src/runtime/index.ts
Outdated
| const d = new Date(str); | ||
| return d instanceof Date && !isNaN(d.getTime()) && d.toISOString() === str; // valid date |
There was a problem hiding this comment.
Do we even need to be this cautious? What are the chances something that matches the ISO pattern is invalid if we’re adding it to the DB?
There was a problem hiding this comment.
Not sure, is there a downside to doing this though (I just grabbed from stackoverflow)
There was a problem hiding this comment.
If it's copied code we now own, I'd just leave a comment to the source
There was a problem hiding this comment.
is there a downside to doing this though
I guess only extra work for each Date parsed? If you fetched a lot of data, you’re now constructing the Date twice for each one. I don’t really mind leaving it in though.
There was a problem hiding this comment.
Removed extra bits, it's just the regex now.
packages/db/src/runtime/index.ts
Outdated
| const d = new Date(str); | ||
| return d instanceof Date && !isNaN(d.getTime()) && d.toISOString() === str; // valid date |
There was a problem hiding this comment.
If it's copied code we now own, I'd just leave a comment to the source
Changes
astro:db: TimeStamps stored usingNOW(in UTC) are being translated to their Local Time value making the JavaScript value of theDateobject inaccurate #10964NOWhelper saves dates as theCURRENT_TIMESTAMP, a UTC date that is unfortunately formated as2024-05-07 17:53:37(no timezone).Testing
Docs
N/A, bug fix