Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prompt for workspace in db link #11032

Merged
merged 6 commits into from
May 21, 2024
Merged

prompt for workspace in db link #11032

merged 6 commits into from
May 21, 2024

Conversation

itsMapleLeaf
Copy link
Contributor

@itsMapleLeaf itsMapleLeaf commented May 13, 2024 •
edited
Loading

Should be merged and released after the Studio PR to list all workspaces

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 492a76d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@itsMapleLeaf itsMapleLeaf marked this pull request as draft May 13, 2024 20:38
@delucis delucis marked this pull request as ready for review May 21, 2024 17:17
@delucis
Copy link
Member

delucis commented May 21, 2024 •
edited
Loading

Updated this PR based on @FredKSchott’s feedback. The flow is now:

  • Link "directory/" with Astro Studio? y/n
    • Yes: Link with an existing project in Astro Studio? y/n
      • Yes: Select your workspace: [assuming there are multiple, skipped if there is only one]
        • What is your project name?
    • No: Create a new project in Astro Studio? y/n
      • Yes: Select your workspace: [as above]
        • What is your new project's name?

matthewp
matthewp approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delucis delucis merged commit b78e83f into main May 21, 2024
13 checks passed
@delucis delucis deleted the 05-13-prompt_for_workspace_in_db_link branch May 21, 2024 19:13
@astrobot-houston astrobot-houston mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredKSchott FredKSchott FredKSchott left review comments

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itsMapleLeaf @delucis @matthewp @FredKSchott