fix(astro): prerendering issue when path contains underscore

[V3RON]

astro/packages/astro/src/core/util.ts

Lines 122 to 129 in 769f11f

	function isPublicRoute(file: URL, config: AstroConfig): boolean {
	const pagesDir = resolvePages(config);
	const parts = file.toString().replace(pagesDir.toString(), '').split('/').slice(1);
	for (const part of parts) {
	if (part.startsWith('_')) return false;
	}
	return true;
	}

Notice the condition in line 124. It checks for the presence of _ in any part of the URL. The problem is that file is an absolute path, so _GITHUB is picked up by this condition, causing the page to be considered 'not public'.

Changes

Updated isPublicRoute to use relative paths, ensuring correct handling of underscore folders outside the repository. This change ensures the function correctly returns 'true' when an underscore folder is present outside the repository folder, as intended.

Closes #11232

Testing

Added automated test to cover edge cases involving underscores in paths.

Docs

No update needed

[changeset-bot]

🦋 Changeset detected

Latest commit: 59d11e7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[V3RON]

Quick note: packages/astro/test/fixtures/_underscore in folder name/node_modules/fake-astro-library/ is there on purpose to simulate case when page is exposed by a third-party library.

[ematipico]

The comment should also explain why this is necessary. The code itself isn't too complicated to understand, so a comment that explains it seems superfluous. However, it's worth adding an explanation of the motive because if you left a comment here, it means there's a particular case to handle :)

[V3RON]

It might happen that a page is located in node_modules, and the Astro project itself is in a path containing the _ character. In such cases, we should use a relative path to bypass the segment containing _.

WDYT?

[matthewp]

great test, thanks!