fix: throw error if rewrite is attempted after body is used #11258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2e7605f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
sarah11918
reviewed
Jun 14, 2024
There was a problem hiding this comment.
Thanks @ascorbic ! Advice looks clear and helpful to the reader! 🙌
Tiny suggestions for your consideration below!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
florian-lefebvre
approved these changes
Jun 14, 2024
ematipico
approved these changes
Jun 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Experimental
Astro.rewrite()clones the request, which throws a confusing error if the body has already been consumed. This PR detects this and throws a more helpful error instead.Fixes #11247
Testing
Adds tests
Docs
@withastro/maintainers-docs This adds a new Astro error