bug: removes type override from defineAction #11292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 94222e7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
jdtjenkins
added
the
- P2: nice to have
ematipico
approved these changes
Jun 20, 2024
florian-lefebvre
approved these changes
Jun 20, 2024
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Merged
ematipico
added a commit
that referenced
this pull request
Jun 25, 2024
This reverts commit 7f8f347.
ematipico
added a commit
that referenced
this pull request
Jun 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes the type override for the
acceptparameter in thedefineActionActions function.Fernando Herrera pointed out earlier that the
acceptparam fordefineActiononly suggestedjsonin the intellisense instead of bothjsonandform.Now I'm not going to pretend I understand everything going on in the typing for the
acceptparam here. But I'm pretty sure the= 'json'here is redundant.https://discord.com/channels/830184174198718474/1252972140161142816/1252996832238506056
Before:
After:
Testing
No tests are necessary here I think?
Docs
No docs are necessary as I think this is a bug fix?