Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getPackage resolve path #11347

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix getPackage resolve path #11347

merged 1 commit into from
Jun 26, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jun 26, 2024

Changes

fix #11344

Refactor the way require.resolve is called. It failed before because the process.cwd() didn't have a trailing slash, so it wasn't resolve from the project directory, but its parent, which doesn't contain the node_modules to check packages for.

I refactored it to use the paths option because it's simpler and we also had a similar code like this.

resolved = require.resolve(entrypoint, { paths: [cwd || fileURLToPath(config.root)] });

Testing

Tested manually by editing the node_modules. I wasn't testing this correctly before because I linked the package, which resolves differently.

Docs

n/a. bug fix.

Copy link

changeset-bot bot commented Jun 26, 2024

🦋 Changeset detected

Latest commit: dc95d67

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm install @astrojs/check typescript ?
2 participants