Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fix #11344
Refactor the way
require.resolve
is called. It failed before because theprocess.cwd()
didn't have a trailing slash, so it wasn't resolve from the project directory, but its parent, which doesn't contain thenode_modules
to check packages for.I refactored it to use the
paths
option because it's simpler and we also had a similar code like this.astro/packages/astro/src/core/routing/manifest/create.ts
Line 347 in dc95d67
Testing
Tested manually by editing the node_modules. I wasn't testing this correctly before because I linked the package, which resolves differently.
Docs
n/a. bug fix.