feat(container): client hydration #11486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 33a8cba The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: react
ematipico
force-pushed
the
fix/client-directives-container
branch
from
cb81286
to
33a8cba
Compare
github-actions
bot
removed
the
pr: docs
ematipico
changed the title
ematipico
changed the title
matthewp
approved these changes
Jul 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a bug inside the container API, where an error was thrown when rendering a client component using
client:*directives.Closes #11407
This issue was brought up on discord: https://discord.com/channels/830184174198718474/1255408685275021342
To fix the bug, I created a new API called
addClientRenderer. This new API is very similar toaddServerRenderer, but it has two restrictions:addServerRenderer. If there's no server renderer, an error is thrown.Testing
Added a new test case
Docs
N/A