Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump typescript-eslint to v8 #11649

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 8, 2024

Changes

Similar to #7425, this:

  1. Updates typescript-eslint dependencies to the v8 beta (https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta)
  2. Fixes straightforward new complaints
  3. Disables not-so-straightforward rules in the ESLint config
  4. ...and that's it - unlike chore: use typescript-eslint@v8's projectService for typed linting #11315, doesn't enable the new project service (because it's not quite ready for this complex a repo!)

Copy link

changeset-bot bot commented Aug 8, 2024

⚠️ No Changeset found

Latest commit: 8a02836

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: preact Related to Preact (scope) pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Aug 8, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Maybe we can look into properly setting up projectService in the future.

@@ -14,7 +14,6 @@ declare namespace astroHTML.JSX {
export type Children = Child | Child[];

interface ElementChildrenAttribute {
// eslint-disable-next-line @typescript-eslint/ban-types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a dream it is to be able to remove these, thank you eslint team 🙏

@bluwy bluwy merged commit 4c1b769 into withastro:main Aug 8, 2024
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the typescript-eslint-8 branch August 8, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants