Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): save error stack trace in memory #11689

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ematipico
Copy link
Member

Changes

Closes #11675

The stack trace of the error is saved in memory across submits. The stack trace is populated only in dev

Testing

I tested it against the reproduction of the issue, and I can successfully see the errors. No warnings regarding the size of the cookie

Docs

N/A

Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: cfc3c32

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 13, 2024
@ematipico ematipico force-pushed the fix/actions-error-stack branch from d34be39 to cfc3c32 Compare August 13, 2024 13:54
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a single-ton for the fix!

@bholmesdev bholmesdev merged commit c7bda4c into main Aug 13, 2024
13 checks passed
@bholmesdev bholmesdev deleted the fix/actions-error-stack branch August 13, 2024 14:47
@astrobot-houston astrobot-houston mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro actions cookies broken, too large sometimes
2 participants