fix: adapter features messaging #11773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 11570ac The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
sarah11918
reviewed
Aug 19, 2024
There was a problem hiding this comment.
Thanks for tackling this so quickly @ematipico ! Here are some thoughts from me. See what you think!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
matthewp
approved these changes
Aug 19, 2024
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
florian-lefebvre
approved these changes
Aug 20, 2024
ematipico
added a commit
that referenced
this pull request
Aug 21, 2024
* fix: adapter features messaging * Apply suggestions from code review Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update .changeset/long-months-burn.md Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com> --------- Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The phrasing was misleading. This PR fixes it
Testing
CI should pass
Docs
/cc @withastro/maintainers-docs for feedback!