fix(assets): Remove TLA by making compiledContent async #11782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c0185fa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
Princesseuh
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thanks @Princesseuh - just checking this is PLT-1323? |
It is, yes |
bluwy
approved these changes
Aug 20, 2024
Merged
ematipico
pushed a commit
that referenced
this pull request
Aug 21, 2024
* fix(assets): Remove TLA by making compiledContent async * fix: actually use the functions I just added lol * chore: changeset
|
How do we fix this in the v4? I'm on Astro v4.14.5 w/ Vercel serverless and getting the error .vercel/output/_functions/chunks/how-to-update-dependencies_SGjbVBJN.mjs:62:16: Updating the dependencies of a pr... Top-level await is not available in the configured target environment ("es2020") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This makes
compiledContent()async so that we can avoid the top level await in our Markdown modules. This fixes many issues regarding bundling image services where due to a Rollup bug (rollup/rollup#4708), Node would suddenly exit with no error messagesTesting
Tests should pass!
Docs
Will do!