Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config options to control URL behavior #1197

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Add config options to control URL behavior #1197

merged 1 commit into from
Aug 23, 2021

Conversation

FredKSchott
Copy link
Member

Changes

  • New config: trailingSlash: 'always' | 'never' | 'ignore'; to resolve 💡 RFC: Trailing slashes #452
  • New config: pageDirectoryUrl: boolean to resolve a secondary part of 💡 RFC: Trailing slashes #452
  • 404.astro now outputs to 404.html instead of 404/index.html to work with Netlify, Vercel, etc.
  • Some small cleanup around configuartion

Testing

  • Tests added.

Docs

  • Docs added.

@FredKSchott FredKSchott requested a review from a team as a code owner August 23, 2021 05:30
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2021

🦋 Changeset detected

Latest commit: 45a9981

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

astro-www – ./www

🔍 Inspect: https://vercel.com/pikapkg/astro-www/6K44Nk1ThBrBe43zxThazZ2GRMXU
✅ Preview: https://astro-www-git-404-output-pikapkg.vercel.app

astro-docs – ./docs

🔍 Inspect: https://vercel.com/pikapkg/astro-docs/9LY6Mwfr8BEgY6VgfT9EyhfyiHMQ
✅ Preview: https://astro-docs-git-404-output-pikapkg.vercel.app

@matthewp
Copy link
Contributor

lgtm

@FredKSchott
Copy link
Member Author

FredKSchott commented Aug 23, 2021

Would normally keep this open for a bit longer after the first LGTM, but merging now so that #1198 can be rebased correctly off of main.

@FredKSchott FredKSchott merged commit c06da5d into main Aug 23, 2021
@FredKSchott FredKSchott deleted the 404-output branch August 23, 2021 19:05
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 RFC: Trailing slashes
2 participants